Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize cmake #52

Closed

Conversation

mattangus
Copy link

This PR moves to a more modern target based CMake usage. This avoids setting properties globally for potential consumers of this project.

@stribor14
Copy link
Collaborator

Hi Matt, thank you for the contribution. I generally agree with the change as a correct direction, but for now I would would like the merge to point to devel-v040 branch as for us this change would mean "breaking API change" (on some of our ROS1 "catkin" deployments we would have to write additional CMakeLists wrapper just to re-add flags again).

Another option would be to "hide" these compile options behind a custom option which could be easily disabled/overridden when including this file in other projects. (e.g. EIGENCPP_OPTFLAGS and EIGEN_FLAGS in OCaml wrapper for eigen for Owl)

@stribor14
Copy link
Collaborator

Additionally, we planned to revisit default compile flags for v0.4.0 release at #48 (e.g., -DNDEBUG, -O3 instead of -O2, etc.), but this will be done at the end after it is feature complete (there are some API changes + new functionalities are still in testing, especially curve offsets and polyline fitting)

@mattangus
Copy link
Author

Closing in favor of: #53

@mattangus mattangus closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants